Skip to content

Fix sudo prompting and clean up provider plugins - #3

Merged
karutoil merged 1 commit into
masterfrom
agent/fix-sudo-password-prompt
Jul 15, 2026
Merged

Fix sudo prompting and clean up provider plugins#3
karutoil merged 1 commit into
masterfrom
agent/fix-sudo-password-prompt

Conversation

@karutoil

Copy link
Copy Markdown
Contributor

What changed

  • Classify non-interactive sudo preflight results so permissive (never) mode prompts only when sudo explicitly requires a password.
  • Run passwordless or cached sudo without a flyout and surface unavailable or denied sudo as normal command errors.
  • Apply the behavior to agent bash calls and user bang commands.
  • Remove obsolete built-in provider and OAuth helpers.
  • Add the plugin-umans provider manifest.

Why

The previous sudo probe treated every non-zero result as a password requirement. Missing sudo, policy denials, and probe failures therefore opened a misleading password prompt even in permissive mode.

Impact

Users in never permission mode no longer receive unnecessary sudo prompts. Non-permissive modes retain their existing approval prompt behavior.

Validation

  • cargo check --manifest-path core/Cargo.toml passes.
  • git diff --check passes.
  • Targeted unit tests are present, but the test build is currently blocked by config.rs tests that still reference the removed preset_has_oauth_creds helper included in this branch.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d2c58b9d-eb64-4157-8cd4-6cd8e6553f63

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/fix-sudo-password-prompt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@karutoil
karutoil merged commit 780c660 into master Jul 15, 2026
7 of 8 checks passed
@karutoil
karutoil deleted the agent/fix-sudo-password-prompt branch July 23, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant